roachtest: log teardown to different file #54687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andreimatei
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andreimatei and @tbg)
pkg/cmd/roachtest/test_runner.go, line 760 at r1 (raw file):
teardownL, err := c.l.ChildLogger("teardown", quietStderr, quietStdout) if err != nil { panic(err)
what's going on here?
You can just return the error I think.
We perform various operations on teardown which typically produce a few pages of log output (dead nodes, consistency, getting logs, ...). These tend to make the real test failure harder to find, so this commit switches out the loggers before we perform teardown; teardown will log to `teardown.log` instead. The main log (`test.log`) now ends as follows: ``` [...] 09:41:06 allocator.go:315: 0 mis-replicated ranges 09:41:07 test.go:337: test failure: allocator.go:321,test_runner.go:755: boom! 09:41:07 test_runner.go:769: tearing down after failure; see teardown.log ``` Release note: None
tbg
force-pushed
the
roachtest-teardown-log
branch
from
c0ee648 to
5537a56
Compare
|
Done. TFTR! |
|
bors r=andreimatei |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We perform various operations on teardown which typically produce a few
pages of log output (dead nodes, consistency, getting logs, ...).
These tend to make the real test failure harder to find, so this
commit switches out the loggers before we perform teardown; teardown
will log to
teardown.loginstead. The main log (test.log) nowends as follows:
Release note: None